Potential problem with Escalation 5.3 patch.

Found a bug with the CensusPlus UI Mod? Post it here!
Post Reply
User avatar
bringoutyourdead
Forums Admin & general flunky
Posts: 1432
Joined: Fri Nov 07, 2008 1:11 pm
Location: Texas, USA

Potential problem with Escalation 5.3 patch.

Post by bringoutyourdead »

Besides the TOC needing an update
I just noticed on my second pass of census runs today that I'm seeing odd results.
/who is returning 50 results instead of the default 49 max
I need to see if this is a valid change on Blizzards part.. if so some tweaks need to be made to the CensusPlus code since the marker to trigger sub-queries will be broken with that change.

User avatar
bringoutyourdead
Forums Admin & general flunky
Posts: 1432
Joined: Fri Nov 07, 2008 1:11 pm
Location: Texas, USA

Post by bringoutyourdead »

Yes there is a problem
When using wholib library all results are being returned as complete even when there is an overflow state and the flag returned should be "not complete".

1974ER
Epic Censi
Posts: 762
Joined: Fri Nov 07, 2008 3:30 am

Post by 1974ER »

EU is down for applying the patch, so I can't check anything at the moment. Even so, thank you for the heads up. This means that for now, the results will be way too low, as the 90s count will max out at 50? And most bigger factions will show faulty results for lower brackets, too?

Thank you for all the hard work, please keep us informed on future developments of this topic.

User avatar
Fett
Census Taker
Posts: 58
Joined: Sat Nov 01, 2008 3:34 am

Post by Fett »

He's already got a patched version up on Curse. It is reporting a newer version number, so last I tried I was unable to upload data collected with that version. For now I'm just collecting data files until the site will accept them again.

1974ER
Epic Censi
Posts: 762
Joined: Fri Nov 07, 2008 3:30 am

Post by 1974ER »

Thanks for heads up, Fett. Replaced and also going stockpile mode still.

User avatar
bringoutyourdead
Forums Admin & general flunky
Posts: 1432
Joined: Fri Nov 07, 2008 1:11 pm
Location: Texas, USA

Post by bringoutyourdead »

Yes I had to up the version number to stop people from using the 6.0.0 version since it fails to properly see all the available people to census.

Unfortunately Metalbeast was working on warcraftrealms last night.. and I didn't have a local copy of his contact info. I have sent messages to two of his contact address requesting that he update the valid version number for uploading.

The baseline problem is that Blizzard changed the way they respond to the /who request.. previously it would return a max of count of 50 but only show 49 to indicate that there were more matches then what could be shown. As of 5.0.3 it now has a max count of 50 and shows 50.

The old baseline straight api coding of CensusPlus has a hard coded limit of 49, which allowed me to quickly get an update out... but we now again clash with any other addon that queries Blizzards who subsystem.

The wholib library version fails because it can't as currently coded see that there is a overflow condition. All queries return as valid and complete.

User avatar
bringoutyourdead
Forums Admin & general flunky
Posts: 1432
Joined: Fri Nov 07, 2008 1:11 pm
Location: Texas, USA

Post by bringoutyourdead »

Good news of sorts...
next patch for censusplus is awaiting QA testing and 3rd party update.

A solution for the Libwho problem has been found and verified.. just waiting for code maintainer to update as needed.

A fix for the CensusPlus button being up during Pet Battle has been coded and is going to QA testing.

These updates will NOT require a CensusPlus version number push.. and you won't need to grab the update unless you are annoyed by the CensusPlus button or have other addons that use Blizzards /who subsystem (e.g. WIM)

As to when the update will happen.. who knows? it isn't under my control.

User avatar
FuxieDK
Census Taker
Posts: 659
Joined: Thu May 22, 2008 11:36 am
Location: Copenhagen, DK

Post by FuxieDK »

bringoutyourdead wrote:A solution for the Libwho problem has been found and verified.. just waiting for code maintainer to update as needed.
Have the guy making LibWho been made aware of this?

It's an external Lib, made by someone else..
Doing census mainly on Draenor; Raluf - Nimsay - Lusmo - Quixx - Sosyan - Garthog - Trubin - Zalistra - Zesmi and Djaang

User avatar
bringoutyourdead
Forums Admin & general flunky
Posts: 1432
Joined: Fri Nov 07, 2008 1:11 pm
Location: Texas, USA

Post by bringoutyourdead »

I have a ticket open on the project page.
the libwho has three maintainers listed... two of which are still active

I'm going to be passive for the Long weekend (U.S.A. has Memorial Day Holiday) and if I don't see anything, I'll give a direct tickle on main coders main public email account to check on status.. The ticket should have already sent an email heads up... but I see that maintainer has been busy updating other addons under her control.

Post Reply