Guild Window pops up during scan

Found a bug with the CensusPlus UI Mod? Post it here!
Post Reply
Psonere
Posts: 42
Joined: Fri Nov 23, 2007 1:07 pm
Location: WA

Guild Window pops up during scan

Post by Psonere »

Since the 2.3 update, the guild window pops up during the scan. I verified it is Census+ causing this during each /who cycle. I do not have spam sentry installed so not sure what is causing it.
Last edited by Psonere on Sat Nov 24, 2007 12:36 am, edited 1 time in total.
GET INVOLVED TODAY!
The WoW Census is made possible by authors like Rollie!
One user can make a huge difference so help keep the WoW Census as accurate as possible by posting bugs today!

User avatar
DM.
Census Taker
Posts: 1130
Joined: Mon Oct 03, 2005 12:27 pm
Location: Toronto, Canada

Post by DM. »

This has been an ongoing issue an one of which Rollie is aware of, and can't easily be solved without re-writing the way CensusPlus does its scans and captures the results. I also hate it... but there isn't anything that can be done atm.... Hopefully he finds time to fix the code, or someone else does. I've been poking around and found a way to get around it, but the way I found breaks other features like doing a /who during a scan.

I would like to post my findings tho if Rollie would give me the ok....
Image
Click my sig

Psonere
Posts: 42
Joined: Fri Nov 23, 2007 1:07 pm
Location: WA

Post by Psonere »

I saw that a few others posted the issue in an unrelated thread, that is why I posted a new thread to find the issue easier.

Since this is not easily fixed, I am really surprised the addon is even used any longer. Not negating the fact that the addon IMO is very helpful, however if people stop using it due to a "bug" in the coding that is VERY annoying. This will make the addon and data gathered become old and outdated quickly.

I wish I knew how to code lua, I want to keep using this addon. However as for now, its disabled until fixed. :cry:

Psonere
Posts: 42
Joined: Fri Nov 23, 2007 1:07 pm
Location: WA

Post by Psonere »

Thanks for the workaround, however even if I don't open any of those windows when I first log in, the guild window pops up when the scan starts.

Also, just because there is a workaround, doesn't mean it shouldn't be fixed. Workarounds are "temporary" fixes until an issue is fully resolved.

Anyways, I was looking at the code and commented out 3 lines and it appears to have resolved the issue for me with only a minor drawback. However the drawback doesn't affect my gameplay so I am good with it now. After a bit more time in game and seeing how the scan go, I will post the lines I commented out.

Psonere
Posts: 42
Joined: Fri Nov 23, 2007 1:07 pm
Location: WA

Post by Psonere »

Ok, I haven't had a problem with the guild window popping up since I made the change. However, be aware that while Census+ is scanning, you will not be able to see anything in the guild social window until (a) you manually stop the scan or (b) the scan finishes.

For me, I only check my guild window about 1-2 times an hour to see who's on. So I rarely see the guild window blank. Anyways, heres my update.

Step One:
First locate your CensusPlus.lua file and find the following section

Code: Select all

-----------------------------------------------------------------------------------
--
-- CensusPlus_FriendsFrame_Update
--
-----------------------------------------------------------------------------------
function CensusPlus_FriendsFrame_Update()
	if ( FriendsFrame.selectedTab == 3 and g_IsCensusPlusInProgress == true and g_WhoAutoClose ) then
		FriendsFrameTopLeft:SetTexture("Interface\\ClassTrainerFrame\\UI-ClassTrainer-TopLeft");
		FriendsFrameTopRight:SetTexture("Interface\\ClassTrainerFrame\\UI-ClassTrainer-TopRight");
		FriendsFrameBottomLeft:SetTexture("Interface\\FriendsFrame\\GuildFrame-BotLeft");
		FriendsFrameBottomRight:SetTexture("Interface\\FriendsFrame\\GuildFrame-BotRight");
		local guildName;
		guildName = GetGuildInfo("player");
		FriendsFrameTitleText:SetText(guildName);
		FriendsFrame_ShowSubFrame("GuildFrame");
	else
		g_Pre_FriendsFrame_Update();
	end
end
Step Two:
Comment out the following three lines. (use -- to comment out lines)

Code: Select all

--		local guildName;
--		guildName = GetGuildInfo("player");
--		FriendsFrame_ShowSubFrame("GuildFrame");
Step Three:
Change the following line to read

Code: Select all

		FriendsFrameTitleText:SetText("Guild Info Shown After Census Update");
And that is it. The guild social panel will not popup anymore and you get a message telling you why. Hope this helps others. 8)

Now a suggestion for Rollie. Using this "workaround" to the Guild Panel popping up. Is there a way to make Census+ "pause" when the guild panel is accessed? If so, that could work to help resolve this issue. Once the guild panel is closed, then Census+ starts again. Just a suggestion and not even sure it can be done.
GET INVOLVED TODAY!
The WoW Census is made possible by authors like Rollie!
One user can make a huge difference so help keep the WoW Census as accurate as possible by posting bugs today!

User avatar
Rollie
Site Admin
Posts: 4783
Joined: Sun Nov 28, 2004 11:52 am
Location: Austin, TX
Contact:

Post by Rollie »

I actually have a bit easier fix locally. I just haven't pushed it live yet as I wanted to test it a bit more and I've been gone a week for the holidays. If all goes smoothly over the next few days, I'll release a new version =)

Thanks for your effort!
phpbb:phpinfo()

Psonere
Posts: 42
Joined: Fri Nov 23, 2007 1:07 pm
Location: WA

Post by Psonere »

Thanks for the update Rollie... I am sure many of us are eagerly awaiting its release.
GET INVOLVED TODAY!
The WoW Census is made possible by authors like Rollie!
One user can make a huge difference so help keep the WoW Census as accurate as possible by posting bugs today!

Psonere
Posts: 42
Joined: Fri Nov 23, 2007 1:07 pm
Location: WA

Post by Psonere »

Hey Rollie...

I know you have been pretty busy figuring out the taint issue with Killing Fields... but any idea on a time frame to get an update to Census?
GET INVOLVED TODAY!
The WoW Census is made possible by authors like Rollie!
One user can make a huge difference so help keep the WoW Census as accurate as possible by posting bugs today!

Hybuir
Gear Dependent Squirrel
Gear Dependent Squirrel
Posts: 1471
Joined: Tue Sep 06, 2005 6:22 am
Location: Austin, TX
Contact:

Post by Hybuir »

my work around for this is simply if you're going to check the guild tab, just go back to the Friend's tab. It will not appear via c+

mocha
Posts: 1
Joined: Thu Nov 01, 2007 11:18 am
Location: Germany

Post by mocha »

I have the same Problem, if I open the Guild, Friend, Chat or Raid Window during the Scan. I have the Problem that randomly this Window during the next few Scans. Sometimes it works and the window may be closed during Scan, but often it pops up and in raid Instances it is really bad :( so I just stop scanning during Raids!

The First Scan does no problems, no window pops up. Sometimes after the second, third or may be tenth Scan it may pop up during gameplay XD I don't know why. But it is randomly **** up ^___^

My Solution is:
Don't open the Friends, Guild, Chat, Who or Raid Window during Scan!

Hope for the Update Rolli, you are our greatest Hope alive :roll:

Psonere
Posts: 42
Joined: Fri Nov 23, 2007 1:07 pm
Location: WA

Post by Psonere »

Yeah, lots of us are hoping for an update soon... However from the sounds of it, it may not be soon since Rollie has so many projects besides WCR that he is working on now. :shock:

All we can do now is hope and pray that an update is released before WotLK :cry:

To be honest, I am a bit surprised it hasn't been released sooner. I normally just remove addons that cause problems and are not updated. If others are like me, then makes me curious if others have just removed this addon since it hasn't been updated for so long.
GET INVOLVED TODAY!
The WoW Census is made possible by authors like Rollie!
One user can make a huge difference so help keep the WoW Census as accurate as possible by posting bugs today!

User avatar
Rollie
Site Admin
Posts: 4783
Joined: Sun Nov 28, 2004 11:52 am
Location: Austin, TX
Contact:

Post by Rollie »

er... ya, I just need to package up this latest version I've been using. And you are right, I'm spread a bit thin...
phpbb:phpinfo()

Tsarmina
Posts: 45
Joined: Sat Aug 19, 2006 3:06 pm
Location: New England, USA

Post by Tsarmina »

Yes please! We would certainly like to have some of that. :D

*leaves a plate of gnome-flavored cookies*

Hybuir
Gear Dependent Squirrel
Gear Dependent Squirrel
Posts: 1471
Joined: Tue Sep 06, 2005 6:22 am
Location: Austin, TX
Contact:

Post by Hybuir »

I can open anything except for the guild tab, if i do, then i just go back to the friends and close it. problem averted.

Psonere
Posts: 42
Joined: Fri Nov 23, 2007 1:07 pm
Location: WA

Post by Psonere »

Thanks Rollie... I honestly would not want to be in your shoes with all the stuff your taking on right now
GET INVOLVED TODAY!
The WoW Census is made possible by authors like Rollie!
One user can make a huge difference so help keep the WoW Census as accurate as possible by posting bugs today!

Psonere
Posts: 42
Joined: Fri Nov 23, 2007 1:07 pm
Location: WA

Post by Psonere »

Well, thanks for the fun everyone...

I am removing the addon and done contributing. I don't use the stats anyways, I was just here to help others who do.

Don't take this the wrong way Rollie, I truly do appreciate the work you do and understand you have other commitments. However, this addon is being neglected and like stated earlier, I normally just don't use un-supported addons. I was sticking around because we kept being told a new version is ready.

And for those who use "workarounds" and want to flame me. Go ahead... "workarounds" are not fixes. What I posted was a workaround, switching to the friends frame is a workaround. However being guildleader now (albeit, very small guild) when I can't see my guild screen or continually have it pop up because I "forgot" to use the friends frame last, it gets annoying. Try updating guild controls when C+ desides to run and you will see what I mean.

Take care all and g'luck with your adventures 8)

Post Reply