Mortal Kombat!!

SilverMist · Post by **SilverMist** » Wed Mar 26, 2008 7:52 pm

I use the MK add all the time. It's very useful for my rogue and of course it's fun. I was wondering if there is going to be an update to 2.4

I know the addon is old and there is a low chance it will be updated. But I would greatly appreciate it. As far as I know there is no other addon that does all the same things as this one. It lets me know when I've been hit by another player and that's very useful. As well, the combat music has saved my ass a time or two. If I need an alternative and if there is one please let me know.

Post by **Rollie** » Thu Mar 27, 2008 5:12 pm

I would have to see what all would need to be done if it requires changes for 2.4

hum4n01dtyph00n · Post by **hum4n01dtyph00n** » Fri Mar 28, 2008 1:44 pm

I would also love to see this mod 'reborn'

It's like my trademark when I crit and "DOMINATING!" comes up. Everyone loves it.

If there's anything I can do to even help you out here I'll do it. Let me know man, the mod is great, needs to be kept going. =)

Thanks

DM. · Post by **DM.** » Fri Mar 28, 2008 2:15 pm

I guess the change to the combat log finally broke Mortal Kombat...

Hybuir · Post by **Hybuir** » Sat Mar 29, 2008 7:30 am

new combat log also broke sct

hum4n01dtyph00n · Post by **hum4n01dtyph00n** » Sun Mar 30, 2008 1:42 am

This mod neeeeeeeeds to be fixed!

Please! I'll help with anything that needs to be done, just let me know.

mkong409 · Post by **mkong409** » Tue Apr 01, 2008 1:53 pm

I've updated MKombat to use the new combat log structure. I'm currently undergoing some testing to make sure it's all working. Once I'm confident it's not doing anything heinous, I'll upload the fixed code.

-Cheers

hum4n01dtyph00n · Post by **hum4n01dtyph00n** » Tue Apr 01, 2008 4:22 pm

I love you if you make it work.

You will be the god of my mods if you get it working haha.

mkong409 · Post by **mkong409** » Tue Apr 01, 2008 4:27 pm

hum4n01dtyph00n wrote:I love you if you make it work.

You will be the god of my mods if you get it working haha.

Well, unfortuantely, my server isn't up yet today, so it may be a bit longer.

hum4n01dtyph00n · Post by **hum4n01dtyph00n** » Tue Apr 01, 2008 4:46 pm

Mine is. O_o

Toss me the mods.

mkong409 · Post by **mkong409** » Tue Apr 01, 2008 7:03 pm

Okay, I've uploaded it to GoogleCode here:

http://mkombatmod.googlecode.com

Try it out, keeping in mind it's beta. I have not been able to test all of the events, so any feedback would be helpful.

The majority of code is the same, I've only fixed the code that required the new combat log modifications.

Known Issues:
----------------
There is a problem with the "UNIT_DIES" combat log item, which does not report when *YOU* are killed. This is scheduled to be fixed in WoW 2.4.2 as per Blizzard. As such, the events when you are killed will not fire (yet).

Because of the way that the combat log now works, I've found under testing that it's possible to crit and get the <20% sound nearly on top of each other (and sometimes overlapping). I'll be working on this.

I have not done any performance enhancements to the code (yet). Please report any issues with performance and I'll work on optimizing it.

Report any misfires of events or bugs, and I'll work on those as well.

*EDIT* Note new URL

hum4n01dtyph00n · Post by **hum4n01dtyph00n** » Wed Apr 02, 2008 11:48 am

Ah you are a god among men my friend.

All i need is for it to yell Dominating! when I crit. Will let you know how it goes.

Thank you.

EDIT: I've found one little problem I believe. When I crit, half the time it plays the sound I ask it to, the other half the time it does not. And when it does play the sound, its quite delayed. Any reason why?

Hybuir · Post by **Hybuir** » Wed Apr 02, 2008 12:48 pm

sounds promising... I'll have to take a look at the code start learning it and such. I hear the guys behind ctmod.net put out a book, gotta look for that too.

mkong409 · Post by **mkong409** » Wed Apr 02, 2008 1:07 pm

hum4n01dtyph00n wrote:EDIT: I've found one little problem I believe. When I crit, half the time it plays the sound I ask it to, the other half the time it does not. And when it does play the sound, its quite delayed. Any reason why?

That one's not mine. The script by default has a limiter to keep music/sounds from playing too often. I know from my mage that crits are streaky by nature, so the script is designed not to fire back to back.

There is a variable in the top of MKombat.lua:

local praiseTimeout = 30;

It's sets the delay in seconds between crit sounds. You can decrease this if you like.

As to a delay, the sound won't actually fire until after the event is picked up in the combat log. If you're lagging, there might be a short delay (especially if you're killing people in Quel'Danas). I haven't noticed a delay too much, but have seen a 1 sec or so delay sometimes when lag is bad. If it's worse than that, let me know.

hum4n01dtyph00n · Post by **hum4n01dtyph00n** » Wed Apr 02, 2008 11:46 pm

Nah it's definately that variable in the MKombat.lua

I've logged off for the night, but next time I get on I'll check.

I'm an enhancement shaman, so shit is critting every 4 to 5 seconds for me. I'll change the variable and let you know.

Thanks for the help.

EDIT: Works like a charm, just had to change that value. Just wanted to say thanks again to mkong409 and Rollie.

hum4n01dtyph00n · Post by **hum4n01dtyph00n** » Fri Apr 04, 2008 3:04 am

Alright, another dilemma I'm having with the sound mod.

I want it to play sounds when I kill players in PvP. Help me out here? It's not working at all.

mkong409 · Post by **mkong409** » Fri Apr 04, 2008 8:42 am

hum4n01dtyph00n wrote:Alright, another dilemma I'm having with the sound mod.

I want it to play sounds when I kill players in PvP. Help me out here? It's not working at all.

That should be working (it did for me yesterday) in Quel'Danas. It's one of the sections I updated. Let me play around with it today.

Was this in the open, battleground, or Arena? Had a sound just played recently? Does it ever fire? (try killing multiple players)

hum4n01dtyph00n · Post by **hum4n01dtyph00n** » Fri Apr 04, 2008 11:49 am

The only sound I'm noticing that plays at all is the crit sound.

In open, bgs, and arena.

mkong409 · Post by **mkong409** » Fri Apr 04, 2008 1:38 pm

hum4n01dtyph00n wrote:The only sound I'm noticing that plays at all is the crit sound.

In open, bgs, and arena.

It's not even playing the "Choose your destiny" when targeting an enemy player?

I've put in some debug code on my system and it's firing all the events properly here. Can you do a /combatlog to start up a combat log? Then go into PvP, kill some players, and post a segment of the log showing you making a kill? The log file will be under [WoW Folder]\Logs

By design, the addon only announces PvP kills. I'm assuming that is what you are referring to. Also, the code is set to only look for people that YOU kill, not one that you've attacked but do not kill. In essence, you have to get the killing blow. Also, you've had to have targeted the player then kill him.

For instance, as a mage, I can AoE without targeting. If I kill someone with say Arcane Explosion without having targeted anyone then the event won't fire. This is original code functionality.

Here is a breakdown of the logic:

If (player killed the unit_that_died) then
----If (unit_that_died was last_pvp_target) then
--------If (player took no damage) announce FLAWLESS
--------If (last_pvp_target was less than 20% and we killed with one blow) announce FATALITY
--------If (last_pvp_target was crit when died) announce BRUTALITY
--------If (not any of the above) announce SUPERB
----End
End

If you're saying you should be getting one of those four conditions, let me see your log and I'll see if there is something wrong that I'm missing.

mkong409 · Post by **mkong409** » Fri Apr 04, 2008 4:46 pm

Okay, I found a typo in the original tags which could cause the FLAWLESS sound to not play properly. I also added some debug code to the player death function to help track your issue.

Download the new version here:
http://mkombatmod.googlecode.com

When you install the new version, go into the game and do a:

/mkombat debug on

When you kill mobs, it will now give the conditionals that it sees. When you kill a PvP target, it will give you the type of kill it was (FLAWLESS, SUPERB, etc).

Load this up, and let me know if you are getting the debug messages without the sound playing.

-Cheers