MoP beta - AddOns enabled

FuxieDK · Post by **FuxieDK** » Sat Jun 30, 2012 3:28 am

As of today (or was it yesterday, maybe??), addons have been enabled on MoP beta..

When trying to open CensusPlus on the beta, the whole game client crash..
Not entirely unexpected, as this also happened on PTR in Cata, without causing problems on Live..

However, it can run, when not opening the window, and what surprised me most, was that both Monks and Pandas are incuded in the census. Not as individual searches ofc, but those that fit into the level ranges..
I can't see, if Horde Pandas are possible to tell apart from Aliance..

Anyway, we need Rollie active NOW, if this addons should have chance of surviving..

Small sample of census data from EU Beta server (Mekka) --> http://www.fuxie.dk/files/CensusPlus-MoP-Beta.rar

I'm quite sure, Rollie will be able to get a Beta-key (if he doesn't already have it) from curse.com --> http://www.curse.com/news/curse/45905-m ... or-authors

Balgair · Post by **Balgair** » Sat Jun 30, 2012 6:03 am

Yep, they were enabled this morning, I'm also getting the crash error, given it seems to happen on every PTR I'm not too worried, although it'd be handy if Rollie (or anyone else!) could track that down and fix it, since it doesn't make testing very easy (I'd be tempted to have a poke at the code to try and pick up lvl 90s if it didn't crash, but too hard to figure stuff out as it is).

ERROR #132 (0x85100084) Fatal exception!

Program: D:\Games\World of Warcraft Beta\WoW-64.exe
ProcessID: 3416
Exception: 0xC000008E (FLT_DIVIDE_BY_ZERO) at 0033:000007FEFDBBCACD

It will find Monks and Pandaren in the census, in Cata beta I could pick up Goblins and Worgen, it finds them when doing a general search of a level range, just obviously won't display them (even if the addon was openable!). I'll email Rollie with a link to this thread and see if he can find the time to respond this time.

Re Alliance/Horde Pandaren; there must be some flag somewhere which will mark them by faction, since they have Alliance or Horde in their tooltips. Whether that can be picked up, is another question, but if needs be I'd guess it'd be possible to stick a marker on the data depending which side you were on when doing the census. For the neutral pandas, I'd suggest marking The Wandering Isle the same as battlegrounds, and not allowing censuses to be run there: pandaren there can't /who outside of it, and people outside it can't /who the neutral pandas in it, and given everyone leaves it by lvl 12 or so, it won't lose much data to just exclude it.

Post by **bringoutyourdead** » Sat Jun 30, 2012 12:28 pm

Balgair wrote:Re Alliance/Horde Pandaren; there must be some flag somewhere which will mark them by faction, since they have Alliance or Horde in their tooltips.

There is and Rollie already uses a variation of it .. wow api call
factionGroup, factionName = UnitFactionGroup("unit") or UnitFactionGroup("name")

Balgair wrote:For the neutral pandas, I'd suggest marking The Wandering Isle the same as battlegrounds, and not allowing censuses to be run there: pandaren there can't /who outside of it, and people outside it can't /who the neutral pandas in it, and given everyone leaves it by lvl 12 or so, it won't lose much data to just exclude it.

A simpler option is to use UnitfactionGroup("self").. if the censusPlus character isn't Horde or Alliance, end census run (and put up a message)

Rollie for his database needs to internally mark A-Pandori and H-Pandori but show them as just Pandorean

The sad part of this is last November when I was looking at letter frequency for a more optimal search approach, I did a complete update of CensusPlus (purely as an exercise for learning Lua and XML coding.) I never bothered sending it to Rollie since it was based on wild ass guess assumptions of what Blizzard would do with Mists.
It fixed programming issues with Deprecated API calls that Rollie uses and Blizzard has announced they are abandoning.
It fixed redundant who API processing by better integrating the wholib library.
and it apparently correctly updated censusplus for the new max level, new classes and new split race.

What is sad about this.. about three months ago I lost all the work I had done.

I could have saved Rollie a third of his work.. since he will need to update/modify his addon, his database, and the website interface.

sigh

FuxieDK · Post by **FuxieDK** » Sat Jun 30, 2012 3:45 pm

bringoutyourdead wrote:What is sad about this.. about three months ago I lost all the work I had done.

Tough luck..

But on the other hand, maybe you can recreate the work, while you still have it in memory?

Balgair · Post by **Balgair** » Tue Jul 03, 2012 2:12 am

Rollie has replied to my email, so at least he's out there somewhere - says he's going to get that beta key and get working on updating Censusplus. He didn't mention a timescale but I'm hoping he really means soon, this time

FuxieDK · Post by **FuxieDK** » Tue Jul 03, 2012 3:32 am

Soon(tm)

Post by **bringoutyourdead** » Tue Jul 03, 2012 4:47 pm

bringoutyourdead wrote:.. wow api call
factionGroup, factionName = UnitFactionGroup("unit") or UnitFactionGroup("name")

A simpler option is to use UnitfactionGroup("self").. if the censusPlus character isn't Horde or Alliance, end census run (and put up a message)

and right out of gethub blizzard diffs on Mists...
local factionGroup = UnitFactionGroup("player");
if ( factionGroup and factionGroup ~= "Neutral" ) then
if ( factionGroup == "Alliance" ) then

so on and so forth.

Post by **bringoutyourdead** » Tue Jul 03, 2012 4:59 pm

FuxieDK wrote:But on the other hand, maybe you can recreate the work, while you still have it in memory?

If it were only that simple. Even Rollie will need time to review what is in his code... as it has a history and is built on a slippery foundation provided by Blizzard. I had spent most of my time working out what items were program variables and what were Blizzard api and stuff. I found that there is a lot of program functions in the addon that are now dead code since Blizzard has made many changes.

I spent much of my free time the past few days just recreating and updating my editor wordfiles for the LUA and Blizzard functions as the ones you can find out in the wild are vary outdated..

Probably by the end of the week I'll be able to offer it to Rollie for his use.. assuming he wants to use it.

Post by **bringoutyourdead** » Mon Jul 09, 2012 12:43 pm

Assistance needed... request for MoP beta testers.

Please run the following macro under the following conditions and let me know what you see as result.

/run local factionGroup, factionName = UnitFactionGroup("player"); print("fgroup = ",factionGroup," ,fName = ",factionName);

Run while logged in as Alliance character
should see fgroup = Alliance ,fname = Localized name of the faction

Run while logged in as Horde character
should see fgroup = Horde ,fname = Localized name of the faction

Run while logged in as start zone non-faction Pandaren character
should see fgroup = something? ,fname = Localized name of something?

The first two runs will verify I got the macro right, the last run will tell us what change if any Blizzard made for characters that are not yet identified as Alliance or Horde.

Currently (pre-MoP) the expected result set for factionGroup is {Alliance | Horde | nil - i.e not defined} I want to see if this has changed.

Balgair · Post by **Balgair** » Tue Jul 10, 2012 4:11 am

Alliance:
fgroup = Alliance ,fname = Alliance

Horde:
fgroup = Horde ,fname = Horde

Pandaren:
fgroup = Neutral ,fname =

Yeah, it's just blank under fname, I didn't miss it out! Hope this helps

Post by **bringoutyourdead** » Tue Jul 10, 2012 10:27 am

Thanks!

Fgroup return was what I expected from the github diff's
fname return coming back as blank.. aka nil isn't unexpected, they haven't updated their localization files yet.

Hybuir · Post by **Hybuir** » Tue Jul 10, 2012 8:30 pm

/RollieSignal

Post by **bringoutyourdead** » Thu Jul 19, 2012 5:42 pm

I have been working on the mod but my work will only be going to Rollie for his use or trashing. It has been sent to Rollie.

The biggest problem with Blizzard adding a dual faction race is that to keep down confusion there must be an easy way to identify the correct faction for the race on the display windows both in mod and here at the website. With the mod you could sort of ignore it and go with an generic picture, but I went with using the racial faction leader (in this case the Monk trainers.)

The second problem was to insure that a player character that wasn't a member of either the Alliance or Horde could not trigger useless census runs or display census information that normally would be seen.

As far as I can tell.. that only major issue I have left with the mod is the background texture upon which all the icons, bars and text display. As it currently exists there is no room for new Races. I propose that the two textures window-left and window-right be recreated as Window-left {race} Window-center {race-class} Window-right {class .. guild and the rest}

Rollie will need to make similar changes for display here on the website.

The kicker.. which may or may not exist .. is how Rollie did his database schema. If he is using Race as a key or even worse a primary key, that makes having a Race that moves from faction to faction a problem. If he is using as I hope Faction-race key then database structure changes won't be needed .. just adding the new race(s) and class.

Since I don't have access to his side of the picture, I haven't a real clue if the changes I made would actually work... but working on the code was informative and interesting.